Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazily generate group-by-item candidates for suggestions #1422

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Sep 24, 2024

When the user specifies an invalid group-by item, suggestions for alternatives are shown to the user. These can be generated lazily to improve performance when there are no errors.

@cla-bot cla-bot bot added the cla:yes label Sep 24, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@plypaul plypaul marked this pull request as ready for review September 24, 2024 18:10
@plypaul plypaul force-pushed the p--short-term-perf--04 branch from 140e51f to 850878b Compare September 24, 2024 20:43
@plypaul plypaul force-pushed the p--short-term-perf--05 branch from 914a85d to 29181fb Compare September 24, 2024 20:43
Base automatically changed from p--short-term-perf--04 to main September 24, 2024 20:48
@plypaul plypaul force-pushed the p--short-term-perf--05 branch from 29181fb to e50b51b Compare September 24, 2024 20:48
@plypaul plypaul merged commit 5c41956 into main Sep 24, 2024
15 checks passed
@plypaul plypaul deleted the p--short-term-perf--05 branch September 24, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants